refactor: remove dead TaskDependencyType and clean up task graph construction#283
Closed
yangshun wants to merge 1 commit intovoidzero-dev:mainfrom
Closed
refactor: remove dead TaskDependencyType and clean up task graph construction#283yangshun wants to merge 1 commit intovoidzero-dev:mainfrom
TaskDependencyType and clean up task graph construction#283yangshun wants to merge 1 commit intovoidzero-dev:mainfrom
Conversation
…nstruction - Remove `TaskDependencyType` unit struct — all task graph edges are explicit `dependsOn` dependencies, so `()` suffices as edge weight. - Simplify `add_dependencies` by removing the now-unnecessary `filter_edge` parameter. - Construct `TaskDisplay` once per task instead of twice (once for error mapping, once for the node). - Fix zero-capacity pre-allocation in `IndexedTaskGraph::load` — the hash maps were sized to `task_graph.node_count()` which was always 0. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskDependencyTypeunit struct — all task graph edges are explicitdependsOndependencies, so()suffices as edge weightadd_dependenciesby removing the always-truefilter_edgeparameterTaskDisplayonce per task instead of twice (once for error mapping, once for the node)task_graph.node_count()which was always 0 at that pointTest plan
cargo test -p vite_task_graph— all 35 tests passcargo test -p vite_task_plan --test plan_snapshots— all cases passcargo check— full workspace compiles cleanly🤖 Generated with Claude Code